Skip to content

Conversation

art049
Copy link
Member

@art049 art049 commented Jul 10, 2025

No description provided.

Copy link

codspeed-hq bot commented Jul 10, 2025

CodSpeed Instrumentation Performance Report

Merging #109 will degrade performances by 7.28%

Comparing cod-1133-handle-rustflags-from-cargoconfigtoml (0926c07) with main (8dffbaf)

Summary

⚡ 7 improvements
❌ 1 regressions
✅ 159 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
recursive[0] 240.3 ns 211.1 ns +13.82%
recursive[5] 320.3 ns 291.1 ns +10.02%
recursive_memoized[BTreeMap<u64, u64>, 0] 371.7 ns 400.8 ns -7.28%
sleep_100ns 566.1 ns 536.9 ns +5.43%
sleep_100us 566.1 ns 536.9 ns +5.43%
sleep_1ms 566.1 ns 536.9 ns +5.43%
sleep_1ns 566.1 ns 536.9 ns +5.43%
sleep_1us 566.1 ns 536.9 ns +5.43%

Copy link

codspeed-hq bot commented Jul 10, 2025

CodSpeed WallTime Performance Report

Merging #109 will degrade performances by 65.65%

Comparing cod-1133-handle-rustflags-from-cargoconfigtoml (0926c07) with main (8dffbaf)

Summary

⚡ 10 improvements
❌ 14 regressions
✅ 130 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
build_vec 217 ns 207 ns +4.83%
large_drop 193.3 µs 165.5 µs +16.84%
large_setup 12 ns 13 ns -7.69%
iter_with_setup 38 ns 47 ns -19.15%
from_elem[2048] 241 ns 256 ns -5.86%
from_elem_decimal[2048] 240 ns 259 ns -7.34%
generate_combinations[7] 2 µs 2 µs -3.55%
graph_coloring[3] 1.2 µs 1.1 µs +4.77%
n_queens_solver[5] 7.4 µs 7.8 µs -5.71%
permutations[4] 2.7 µs 2.8 µs -5.11%
permutations[6] 66.4 µs 70.8 µs -6.22%
rat_in_maze[6] 698 ns 728 ns -4.12%
rat_in_maze[7] 797 ns 827 ns -3.63%
rat_in_maze[8] 920 ns 956 ns -3.77%
add_two_integers[(42, 13)] 20 ns 6 ns ×3.3
count_set_bits[0] 8 ns 7 ns +14.29%
count_set_bits[1024] 8 ns 7 ns +14.29%
count_set_bits[255] 8 ns 7 ns +14.29%
count_set_bits[42] 8 ns 7 ns +14.29%
count_set_bits[65535] 8 ns 7 ns +14.29%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review July 11, 2025 10:30
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1133-handle-rustflags-from-cargoconfigtoml branch from 20e4190 to 0741e5f Compare July 11, 2025 10:32
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1133-handle-rustflags-from-cargoconfigtoml branch from 0741e5f to b8f25dd Compare July 11, 2025 10:35
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments about the style, looks great good otherwise!

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1133-handle-rustflags-from-cargoconfigtoml branch 4 times, most recently from aaf9874 to 8c4971f Compare July 11, 2025 14:12
With the fix from previous commit, the `--cfg codspeed` would be caught
by the cargo config of the repo.
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1133-handle-rustflags-from-cargoconfigtoml branch from bfc67e4 to 0926c07 Compare July 11, 2025 15:06
@GuillaumeLagrange GuillaumeLagrange merged commit 0926c07 into main Jul 11, 2025
13 of 14 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1133-handle-rustflags-from-cargoconfigtoml branch July 11, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants