Skip to content

Add test environment setup and improve test documentation #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test environment setup and improve test documentation #53

wants to merge 1 commit into from

Conversation

ddobrinskiy
Copy link

@ddobrinskiy ddobrinskiy commented Jun 11, 2025 •
edited
Loading

This PR

  1. adds a tests/test.env file with default ClickHouse test configuration
  2. updates the README with a one-liner command to run tests with default environment variables (from the tests/test.env file above)

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ddobrinskiy
ddobrinskiy commented Jun 11, 2025
View reviewed changes
README.md
@@ -216,8 +216,8 @@ You can set these variables in your environment, in a `.env` file, or in the Cla
uv sync --all-extras --dev # install dev dependencies
uv run ruff check . # run linting

docker compose up -d test_services # start ClickHouse
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default command fails:

➜  test-services ✗ docker compose up -d test_services
no such service: test_services

ddobrinskiy
ddobrinskiy commented Jun 11, 2025
View reviewed changes
Copy link
Author

@ddobrinskiy ddobrinskiy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for review

README.md
@@ -216,8 +216,8 @@ You can set these variables in your environment, in a `.env` file, or in the Cla
uv sync --all-extras --dev # install dev dependencies
uv run ruff check . # run linting

docker compose up -d test_services # start ClickHouse
uv run pytest tests
docker compose up -d clickhouse # start ClickHouse
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the fix: runs smoothly, and tests are passing
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passing tests:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddobrinskiy @CLAassistant