-Werror,-Wimplicit-function-declaration in lib/devres.c in -next

[nickdesaulniers]

Trying to build hexagon in linux next, I'm running into what looks like an upstream bug:

$ ARCH=hexagon CROSS_COMPILE=hexagon-linux-gnu- make -j71 CC=clang AS=clang LD=ld.lld AR=llvm-ar
...
lib/devres.c:44:10: error: implicit declaration of function 'ioremap_uc' [-Werror,-Wimplicit-function-declaration]
                addr = ioremap_uc(offset, size);
                       ^
lib/devres.c:44:10: note: did you mean 'ioremap'?
./arch/hexagon/include/asm/io.h:174:15: note: 'ioremap' declared here
void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
              ^
lib/devres.c:44:8: warning: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
                addr = ioremap_uc(offset, size);
                     ^ ~~~~~~~~~~~~~~~~~~~~~~~~

cc @androm3da

(I've extracted Sid's patches out from https://github.com/androm3da/continuous-integration/tree/hexagon_02_dec_2019/patches/llvm-all/linux/hexagon)

[nathanchance]

Looks like https://git.kernel.org/linus/e537654b7039aacfe8ae629d49655c0e5692ad44 didn't take into account hexagon.

[nathanchance]

Probably just need something like https://git.kernel.org/linus/38e45d81d14e5f78cd67922596b1c37b4c22ec74.

[androm3da]

Probably just need something like https://git.kernel.org/linus/38e45d81d14e5f78cd67922596b1c37b4c22ec74.

Thanks, I will take a look and make a similar patch.

[nickdesaulniers]

From 6ebae81252cde58881b3400a5c8d40c785be8c22 Mon Sep 17 00:00:00 2001
From: Nick Desaulniers <ndesaulniers@google.com>
Date: Mon, 9 Dec 2019 14:10:47 -0800
Subject: [PATCH] hexagon: define ioremap_uc

Similar to
commit 38e45d81d14e ("sparc64: implement ioremap_uc")
define ioremap_uc for hexagon to avoid errors from
-Wimplicit-function-definition.

Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 arch/hexagon/include/asm/io.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
index 539e3efcf39c..b0dbc3473172 100644
--- a/arch/hexagon/include/asm/io.h
+++ b/arch/hexagon/include/asm/io.h
@@ -173,6 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
 
 void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
 #define ioremap_nocache ioremap
+#define ioremap_uc(X, Y) ioremap((X), (Y))
 
 
 #define __raw_writel writel
-- 
2.24.0.393.g34dc348eaf-goog

[nickdesaulniers]

submitted: https://lore.kernel.org/r/20191209222956.239798-2-ndesaulniers@google.com/

[nickdesaulniers]

accepted (http://ozlabs.org/~akpm/mmots/broken-out/hexagon-define-ioremap_uc.patch / http://ozlabs.org/~akpm/mmotm/broken-out/hexagon-define-ioremap_uc.patch)