Add retry delay #66
Merged
Add retry delay #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sminot
approved these changes
Apr 19, 2023
Contributor
sminot
left a comment
sminot
left a comment
There was a problem hiding this comment.
Looks great -- let's just be sure to document the pausing behavior appropriately
|
|
||
| You can set the `base_url` property in the config file rather than using the environment variable. | ||
|
|
||
| The `transfer_max_retries` configuration property specifies the maximum number of times to attempt uploading a file to Cirro in the event of a transfer failure. |
Contributor
There was a problem hiding this comment.
Add text:
After each failed upload attempt there will be a 1-2 minute pause before retrying the upload.
| except S3UploadFailedError as e: | ||
|
|
||
| except (S3UploadFailedError, ConnectionError) as e: | ||
| delay = random.uniform(0, 60) + retry * 60 |
Contributor
There was a problem hiding this comment.
So each retry takes longer and longer?
Contributor
Author
There was a problem hiding this comment.
yeah it adds about a minute to each retry
shanosborne
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delay when retrying upload and make the retry count configurable