Skip to content

Allow _format_share function to work with regular Dataset objects #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Allow _format_share function to work with regular Dataset objects #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cirro/cli/interactive/download_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@
from cirro.utils import format_date


def _format_share(dataset: DatasetWithShare) -> str:
return f'({dataset.share.name})' if dataset.share else ''
def _format_share(dataset: Dataset | DatasetWithShare) -> str:
Copy link
Contributor

@wleepang wleepang Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought the parent class of Dataset is all that is needed here.

if isinstance(dataset, DatasetWithShare) and dataset.share:
return f'({dataset.share.name})'
return ''


def ask_dataset(datasets: List[DatasetWithShare], input_value: str) -> str:
def ask_dataset(datasets: List[Dataset], input_value: str) -> str:
if len(datasets) == 0:
raise InputError("No datasets available")
sorted_datasets = sorted(datasets, key=lambda d: d.created_at, reverse=True)
Expand Down
Loading