Skip to content

Conversation

@nathanthorpe
Copy link
Contributor

@nathanthorpe nathanthorpe commented Jun 27, 2024

CI-211

  • Accept Path-like objects on the upload_file related functions.
  • Add automated test for confirming that it supports object key naming to the correct relative location.
  • Add PathLike type hint to confirm that both directory and files are the same type.
  • Remove reference to "local"
  • Improve file size display (so it supports more than GB).

@sonarqubecloud
Copy link

@nathanthorpe nathanthorpe changed the title Refactor file upload methods to accept Path-like objects CI-211 - Refactor file upload methods to accept Path-like objects Jun 27, 2024
@nathanthorpe nathanthorpe changed the title CI-211 - Refactor file upload methods to accept Path-like objects Refactor file upload methods to accept Path-like objects Jun 27, 2024
@nathanthorpe nathanthorpe requested a review from a team June 27, 2024 18:50
@nathanthorpe nathanthorpe merged commit 3a189f7 into main Jun 27, 2024
@nathanthorpe nathanthorpe deleted the pathlike-upload branch June 27, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants