Skip to content

try to fix ci #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 24, 2023
Merged

try to fix ci #209

merged 13 commits into from
Jul 24, 2023

Conversation

paulirish
Copy link
Member

despite using node 18.. we're getting a Invalid or unexpected token on optional chaining.. aka thing?.prop. shrug.

paulirish
paulirish commented Jul 24, 2023
View reviewed changes
Copy link
Member Author

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are mostly a no-op now. but. it took a bit to find that #207 was the culprit.

@paulirish paulirish merged commit 03a1a80 into master Jul 24, 2023
@paulirish paulirish deleted the paulirish-patch-1 branch July 24, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulirish