sanitize some unescaped HTML from CDP #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
suggested changes
Jul 19, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 20, 2023
Bug: ChromeDevTools/debugger-protocol-viewer#202 Change-Id: Ifcf053d1f97e0daf8741b5abf469d7e8e9e69202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4704893 Commit-Queue: Paul Irish <[email protected]> Commit-Queue: Andrey Kosyakov <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Auto-Submit: Paul Irish <[email protected]> Cr-Commit-Position: refs/heads/main@{#1173148}
thiagowfx
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing this:
see the actual fixes this makes in the generated HTML: https://gist.github.com/paulirish/f7f86e982487a23f494b6c834841743f
We should fix a bunch of these in the PDL and write some validation there so new raw HTML can't be introduced without backticks.
R=@thiagowfx
cc @OrKoN