[ENG-9740] Fix versioned guid resolution #11438
Open
+65
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, if a preprint have more than one version, the
guidsendpoint will always redirect to the latest version even if we specify the version number in the guid. This is because theget_redirect_url()hook inGuidDetailwill try to return the referent'sabsolute_api_v2_urlproperty, which for preprint is based onself._id.Preprintinherits from theVersionedGuidMixinwhich overrides the_idproperty to always return guid string with the latest version.This fix specifies a
get_versioned_absolute_api_v2_urlin theVersionedGuidMixinbase class and implements the method in thePreprintmodel class.Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket