Skip to content

[ENG-9064] When creating file guid through API, needs to work for people with read perms #11341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

[ENG-9064] When creating file guid through API, needs to work for people with read perms #11341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions api/files/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
FileDetailSerializer,
FileVersionSerializer,
)
from osf.utils.permissions import ADMIN


class FileMixin:
Expand Down Expand Up @@ -87,11 +86,11 @@ def get_target(self):

# overrides RetrieveAPIView
def get_object(self):
user = utils.get_user_auth(self.request).user
file = self.get_file()

if self.request.GET.get('create_guid', False):
if (self.get_target().has_permission(user, ADMIN) and utils.has_admin_scope(self.request)):
auth = utils.get_user_auth(self.request)
if self.get_target().can_view(auth):
file.get_guid(create=True)

# We normally would pass this through `get_file` as an annotation, but the `select_for_update` feature prevents
Expand Down
Loading