Skip to content

[ENG-9022] Custom html host for legacy OSF #11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

[ENG-9022] Custom html host for legacy OSF #11338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a46ff87
custom html host for legacy OSF
ihorsokhanexoft Sep 29, 2025
77acbf4
fixed html links, added a test
ihorsokhanexoft Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions api/base/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,6 +1183,13 @@ def to_representation(self, obj):
if hasattr(obj, 'get_absolute_info_url'):
ret['info'] = self._extend_url_with_vol_key(obj.get_absolute_info_url())

request = self.context['request']
referer = request.headers.get('Referer', '')
if 'html' in ret and 'legacy' in referer:
parsed_html_url = urlparse(ret['html'])
legacy_url = urlparse(referer)
ret['html'] = parsed_html_url._replace(scheme=legacy_url.scheme, netloc=legacy_url.netloc).geturl()

return ret


Expand Down
10 changes: 10 additions & 0 deletions api_tests/nodes/views/test_node_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,16 @@ def test_current_user_permissions(self, app, user, url, public_project, non_cont
res = app.get(url_public, auth=superuser.auth)
assert permissions.READ not in res.json['data'][0]['attributes']['current_user_permissions']

def test_legacy_host_for_htmls(self, app, url, public_project):
settings.DOMAIN = 'https://staging3.osf.io'
current_domain_response = app.get(url).json['data']
assert current_domain_response[-1]['links']['html'].startswith(settings.DOMAIN)

# mock request from legacy OSF domain to staging3 backend
# so that backend uses it to generate html links instead of current domain
legacy_domain_response = app.get(url, headers={'Referer': 'http://legacy.osf.io'}).json['data']
assert legacy_domain_response[-1]['links']['html'].startswith('http://legacy.osf.io')


@pytest.mark.django_db
@pytest.mark.enable_bookmark_creation
Expand Down
Loading