Skip to content

Fixed codacy warnings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Fixed codacy warnings #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 27 additions & 28 deletions src/OpenStreetMap-esp32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,46 +392,45 @@ bool OpenStreetMap::saveMap(const char *filename, LGFX_Sprite &sprite, String &r
uint32_t biClrImportant = 0;

// Write BMP header
file.write((uint8_t *)&bfType, 2);
file.write((uint8_t *)&bfSize, 4);
file.write((uint8_t *)&bfReserved, 2);
file.write((uint8_t *)&bfReserved, 2);
file.write((uint8_t *)&bfOffBits, 4);

file.write((uint8_t *)&biSize, 4);
file.write((uint8_t *)&biWidth, 4);
file.write((uint8_t *)&biHeight, 4);
file.write((uint8_t *)&biPlanes, 2);
file.write((uint8_t *)&biBitCount, 2);
file.write((uint8_t *)&biCompression, 4);
file.write((uint8_t *)&biSizeImage, 4);
file.write((uint8_t *)&biXPelsPerMeter, 4);
file.write((uint8_t *)&biYPelsPerMeter, 4);
file.write((uint8_t *)&biClrUsed, 4);
file.write((uint8_t *)&biClrImportant, 4);
file.write(reinterpret_cast<const uint8_t*>(&bfType), sizeof(bfType));
file.write(reinterpret_cast<const uint8_t*>(&bfSize), sizeof(bfSize));
file.write(reinterpret_cast<const uint8_t*>(&bfReserved), sizeof(bfReserved));
file.write(reinterpret_cast<const uint8_t*>(&bfOffBits), sizeof(bfOffBits));

file.write(reinterpret_cast<const uint8_t*>(&biSize), sizeof(biSize));
file.write(reinterpret_cast<const uint8_t*>(&biWidth), sizeof(biWidth));
file.write(reinterpret_cast<const uint8_t*>(&biHeight), sizeof(biHeight));
file.write(reinterpret_cast<const uint8_t*>(&biPlanes), sizeof(biPlanes));
file.write(reinterpret_cast<const uint8_t*>(&biBitCount), sizeof(biBitCount));
file.write(reinterpret_cast<const uint8_t*>(&biCompression), sizeof(biCompression));
file.write(reinterpret_cast<const uint8_t*>(&biSizeImage), sizeof(biSizeImage));
file.write(reinterpret_cast<const uint8_t*>(&biXPelsPerMeter), sizeof(biXPelsPerMeter));
file.write(reinterpret_cast<const uint8_t*>(&biYPelsPerMeter), sizeof(biYPelsPerMeter));
file.write(reinterpret_cast<const uint8_t*>(&biClrUsed), sizeof(biClrUsed));
file.write(reinterpret_cast<const uint8_t*>(&biClrImportant), sizeof(biClrImportant));

for (int y = 0; y < sprite.height(); y++)
{
for (int x = 0; x < sprite.width(); x++)
{
uint16_t color = sprite.readPixel(x, y); // Read pixel color (RGB565 format)
uint8_t r = (color >> 11) & 0x1F;
uint8_t g = (color >> 5) & 0x3F;
uint8_t b = color & 0x1F;
uint16_t rgb565Color = sprite.readPixel(x, y); // Read pixel color (RGB565 format)
uint8_t red5 = (rgb565Color >> 11) & 0x1F;
uint8_t green6 = (rgb565Color >> 5) & 0x3F;
uint8_t blue5 = rgb565Color & 0x1F;

// Convert RGB565 to RGB888
r = (r * 255) / 31;
g = (g * 255) / 63;
b = (b * 255) / 31;
uint8_t red8 = (red5 * 255) / 31;
uint8_t green8 = (green6 * 255) / 63;
uint8_t blue8 = (blue5 * 255) / 31;

file.write(b);
file.write(g);
file.write(r);
file.write(blue8);
file.write(green8);
file.write(red8);
}
}

file.close();
SD.end();
result = "Screenshot saved";
return true;
}
}