Downloading tags and existing classifications. Also new function to download tagged image data for training. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually remove module getting hack and creds
…ng integers only though? Works currently but upload function needs to be checked
andrebriggs
reviewed
Nov 16, 2018
| self.y_min = y_min | ||
| self.y_max = y_max | ||
| self.classification_names = classification_names | ||
| self.image_height = image_height |
There was a problem hiding this comment.
@mtarng so this doesn't reflect the db table now? It seems like we have overloaded this class to fit multiple needs. What to clients of ImageTag enter for height and width when creating ImageTag objects?
| logging.debug("Existing ImageTag found, appending classification {}", row[6]) | ||
| tag_id_to_ImageTag[tag_id].classification_names.append(row[6].strip()) | ||
| else: | ||
| logging.debug("No existing ImageTag found, creating new ImageTag: " |
There was a problem hiding this comment.
@mtarng I would suggest putting this in a method
| for row in cursor: | ||
| logging.debug(row) | ||
| classification_set.add(row[0]) | ||
| logging.debug("Got back {} classifications existing in db.".format(len(classification_set))) |
There was a problem hiding this comment.
@mtarng missing {0} ?
andrebriggs
approved these changes
Nov 19, 2018
bnookala
pushed a commit
to bnookala/active-learning-detect
that referenced
this pull request
Dec 19, 2018
…ownload tagged image data for training. (CatalystCode#42) * Getting tag queries back. Need to construct into data map, also eventually remove module getting hack and creds * Have working list of imageTags returning now * Download of existing tags working now. Unsure about filenames all being integers only though? Works currently but upload function needs to be checked * Retreving existing tags in db * scrubbing creds * comment cleanup * creating function to download tagged images and their data * print -> logging * feedback
abfleishman
pushed a commit
to abfleishman/active-learning-detect
that referenced
this pull request
Oct 10, 2019
tests for prediction flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.