Skip to content

Conversation

@xgdgsc
Copy link
Contributor

@xgdgsc xgdgsc commented Jul 25, 2023

I find shutils only use PATH rather than sys.path. In jupyter it usually is the environment of the jupyter rather than the kernel. Adding this helps it search for castxml.

@iMichka iMichka changed the title add search_path arg Add search_path arg Jul 31, 2023
@iMichka
Copy link
Collaborator

iMichka commented Jul 31, 2023

Hi. I added a comment and made a some minor style changes. Let me know if this is fine for you and I'll merge it.
MacOS build is failing but this is unrelated.

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Aug 1, 2023

Fine.

@iMichka iMichka merged commit 72d0a20 into CastXML:develop Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants