onEditEvent is not triggered when adding a new key

[akuchuk-amplify]

hi! The onEditEvent perfectly tracks the state of editing existing keys/values, but it isn't triggered on adding a new key, which is technically the same. Is it possible to track the Add a new key event somehow? Thanks!

[CarlosNZ]

Thanks for letting me know. I'll investigate and fix.

[CarlosNZ]

Ohh, I've just realised why I didn't make it do this originally. The onEditEvent is specifically for capturing UI interactions, namely turning a UI element into an edit box, and vice versa.

When you add (or delete) a key, this already fires a callback -- the onUpdate function. So you can use that to record the result of adding or deleting keys.

Then again, were you specifically talking about the initiating of the UI input for adding a new key, which happens before it's actually added to the data structure i.e:

I guess I should be able to add an event call for that too, though I'll have to think about the format (since it technically doesn't have a path yet).

[akuchuk-amplify]

Yes, I was referring to the state of adding a new key. onUpdate gets fired after a key is added. Essentially, I was trying to track when the commit/discard buttons are displayed and update some outer component's state based on that.

[CarlosNZ]

Yes, I was referring to the state of adding a new key. onUpdate gets fired after a key is added. Essentially, I was trying to track when the commit/discard buttons are displayed and update some outer component's state based on that.

Ok cool, then I think this PR will do what you're after: #210

[CarlosNZ]

@akuchuk-amplify Out now: https://www.npmjs.com/package/json-edit-react/v/1.28.0

Thanks for the suggestion 👍

[akuchuk-amplify]

cool, thank you for the awesome lib!