Skip to content

schema/v5.0: require at least one English-language description #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2021
Merged

schema/v5.0: require at least one English-language description #114

merged 1 commit into from
Oct 8, 2021

Conversation

@rsc
Copy link
Contributor

@rsc rsc commented Oct 6, 2021 •
edited
Loading

Per CNA rules, descriptions must contain at least one English-language description,
which we take to mean a BCP 47 language tag beginning with "en".

Fixes #112.

@rsc
schema/v5.0: require at least one English-language description
5d29b24 
Per CNA rules, descriptions must contain at least one English-language description,
which we take to mean a BCP 47 language tag beginning with "en".

Fixes CVEProject#112.
@chandanbn
Copy link
Collaborator

chandanbn commented Oct 8, 2021

Looks good to me, Thank you Russ for fixing this.

I see ajv throws this error when no English entries are present:

{
    instancePath: '/containers/cna/descriptions',
    schemaPath: '#/contains',
    keyword: 'contains',
    params: { minContains: 1 },
    message: 'must contain at least 1 valid item(s)'
  },

@chandanbn chandanbn merged commit df8b00d into CVEProject:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EvansJonathan EvansJonathan Awaiting requested review from EvansJonathan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Codify "at least one English entry" requirements for CNA descriptions

2 participants

@rsc @chandanbn