Fix(Fall Hacks 2025): Gallery not centered on small screens #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: On smaller screens, when the gallery images wrapped to a single column, the images would become left-aligned. Root cause: The size of the images were hard coded to be 17.5rem. This meant that if the gallery wrapped the images would be aligned to the left. Solution: Changed the gallery to use grid instead. The images will now attempt to grow to fill the column, unless the column has 17.5rem or higher of horizontal space. At that point, a new column will be made and the row will accommodate another image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
On smaller screens, when the gallery images wrapped to a single column, the images would become left-aligned.
Root cause:
The size of the images were hard coded to be 17.5rem. This meant that if the gallery wrapped the images would be aligned to the left.
Solution:
Changed the gallery to use grid instead. The images will now attempt to grow to fill the column, unless the column has 17.5rem or higher of horizontal space. At that point, a new column will be made and the row will accommodate another image.