Update fork

[CLNMR]

Summary by Sourcery

Modernize CI and code generation by refactoring the shelf_router_generator to the latest analyzer API, bumping package versions and dependency constraints to support Dart 3.5+, adding issue tracker links and badges, updating GitHub Actions workflows with an expanded Dart matrix and permissions, and aligning generated code and tests with the new webSocketHandler ConnectionCallback signature.

New Features:

• Add issue tracker links to all package pubspecs and include an "Issues" column in the repository README.

Bug Fixes:

• Correct typos in changelogs and doc comments across shelf and related packages.

Enhancements:

• Refactor shelf_router_generator to use the newer analyzer element2 API, update code_builder usage, and simplify generated router methods.
• Bump versions and update dependency constraints for shelf_router_generator, shelf_web_socket, and shelf_test_handler to target Dart 3.5 and newer package versions.
• Inline router calls in generated example and test code and adjust code formatting throughout the repo.

Build:

• Add per-package analysis_options.yaml including dart_flutter_team_lints and grant consistent lint settings across all packages.

CI:

• Update GitHub Actions workflows: bump mono_repo version, update actions/cache, setup-dart, labeler, and stale actions versions; add a Dart SDK matrix for multiple versions and platforms; and grant permissions for the publish workflow.

Documentation:

• Refresh the main README with issue tracker badges and update examples to match webSocketHandler’s new ConnectionCallback signature.

Tests:

• Adjust shelf_web_socket and shelf_test_handler tests for the revised ConnectionCallback API and update SDK constraints in CI test jobs.

[sourcery-ai]

Reviewer's Guide

This PR overhauls the CI workflows with expanded Dart SDK coverage and updated action versions, migrates the shelf_router_generator to the analyzer element2 API with refactored code generation, introduces a typed ConnectionCallback in shelf_web_socket, bumps versions and dependency constraints across all shelf packages, and enhances documentation and lint settings.

Class diagram for shelf_web_socket ConnectionCallback and WebSocketHandler changes

classDiagram
  class WebSocketHandler {
    - ConnectionCallback _onConnection
    - Set<String>? _protocols
    - Set<String>? _allowedOrigins
    - Duration? _pingInterval
    + WebSocketHandler(ConnectionCallback onConnection, ...)
  }
  class ConnectionCallback {
    <<typedef>>
    + void Function(WebSocketChannel webSocket, String? subprotocol)
  }
  WebSocketHandler --> ConnectionCallback

Loading

File-Level Changes

Change	Details	Files
Revamp GitHub CI workflows and expand Dart matrix	Upgrade mono_repo, actions/cache, setup-dart, labeler and stale action versions Renumber jobs and add CI tasks for Dart 3.4, 3.5, 3.9, and dev channels Adjust cache keys, job dependencies and matrix package lists	.github/workflows/dart.yml .github/workflows/publish.yaml .github/workflows/no-response.yml .github/workflows/pull_request_label.yml tool/ci.sh
Migrate shelf_router_generator to element2 API and refactor code generation	Switch imports from analyzer element to element2 and update TypeChecker.typeNamed usage Refactor code_builder invocations to builder lambdas and switch expressions Simplify generated router calls in example and test outputs	pkgs/shelf_router_generator/lib/src/shelf_router_generator.dart pkgs/shelf_router_generator/lib/builder.dart pkgs/shelf_router_generator/example/main.g.dart pkgs/shelf_router_generator/test/server/service.g.dart pkgs/shelf_router_generator/test/server/api.g.dart pkgs/shelf_router_generator/test/server/server.dart pkgs/shelf_router_generator/pubspec.yaml pkgs/shelf_router_generator/CHANGELOG.md pkgs/shelf_router_generator/analysis_options.yaml
Introduce typed ConnectionCallback in shelf_web_socket	Add ConnectionCallback typedef and enforce onConnection signature Update webSocketHandler API, imports, and documentation Revise examples and tests to handle two-parameter handler Bump shelf_web_socket to version 3.0.1	pkgs/shelf_web_socket/lib/src/web_socket_handler.dart pkgs/shelf_web_socket/lib/shelf_web_socket.dart pkgs/shelf_web_socket/pubspec.yaml pkgs/shelf_web_socket/CHANGELOG.md pkgs/shelf_web_socket/test/web_socket_test.dart pkgs/shelf_web_socket/README.md pkgs/shelf_web_socket/example/example.dart pkgs/shelf_web_socket/analysis_options.yaml
Bump package versions and update dependencies across shelf suite	Raise version and SDK constraints in pubspecs Add issue_tracker links to each package pubspec Upgrade dependencies (analyzer, build, source_gen, http_methods, etc.)	pkgs/shelf/pubspec.yaml pkgs/shelf_packages_handler/pubspec.yaml pkgs/shelf_proxy/pubspec.yaml pkgs/shelf_router/pubspec.yaml pkgs/shelf_router_generator/pubspec.yaml pkgs/shelf_static/pubspec.yaml pkgs/shelf_test_handler/pubspec.yaml pkgs/shelf_web_socket/pubspec.yaml
Enhance documentation and lint configurations	Add issue badges column to README package table Include dart_flutter_team_lints in all analysis_options Apply minor grammar fixes and add missing imports in shelf core modules	README.md analysis_options.yaml pkgs/shelf/analysis_options.yaml pkgs/shelf_packages_handler/analysis_options.yaml pkgs/shelf_proxy/analysis_options.yaml pkgs/shelf_router/analysis_options.yaml pkgs/shelf_router_generator/analysis_options.yaml pkgs/shelf_static/analysis_options.yaml pkgs/shelf_test_handler/analysis_options.yaml pkgs/shelf_web_socket/analysis_options.yaml pkgs/shelf/lib/src/message.dart pkgs/shelf/lib/src/middleware_extensions.dart pkgs/shelf/lib/src/pipeline.dart pkgs/shelf/lib/src/response.dart pkgs/shelf/lib/src/body.dart pkgs/shelf/lib/src/hijack_exception.dart pkgs/shelf_test_handler/lib/src/expectation.dart pkgs/shelf_test_handler/lib/src/server.dart pkgs/shelf/lib/src/server.dart

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

Blocking issues:

• Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections. (link)

General comments:

• The testGet helper in server_test.dart now shadows the result parameter and ends up comparing the response to itself, so please rename variables and assert against the expected value (e.g. status/body) instead of equals(result).
• The CI workflow YAML is extremely verbose and error-prone with duplicated job definitions for each SDK/package combo – consider using a matrix strategy to DRY it up and reduce maintenance overhead.
• The change to webSocketHandler drops the fallback for single-argument callbacks, which could break existing users – either preserve that backward compatibility or clearly document and deprecate the old signature.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `testGet` helper in `server_test.dart` now shadows the `result` parameter and ends up comparing the response to itself, so please rename variables and assert against the expected value (e.g. status/body) instead of `equals(result)`.
- The CI workflow YAML is extremely verbose and error-prone with duplicated job definitions for each SDK/package combo – consider using a matrix strategy to DRY it up and reduce maintenance overhead.
- The change to `webSocketHandler` drops the fallback for single-argument callbacks, which could break existing users – either preserve that backward compatibility or clearly document and deprecate the old signature.

## Individual Comments

### Comment 1
<location> `pkgs/shelf_web_socket/lib/src/web_socket_handler.dart:12` </location>
<code_context>
 import 'package:web_socket_channel/io.dart';
 import 'package:web_socket_channel/web_socket_channel.dart';

+/// Used by `webSocketHandler` report connections back to callers.
+///
+/// This takes a [WebSocketChannel] as its first argument and an optional
</code_context>

<issue_to_address>
**issue:** Added ConnectionCallback typedef for connection handling.

Defining this typedef enhances maintainability and makes the API usage clearer.
</issue_to_address>

### Comment 2
<location> `pkgs/shelf_web_socket/lib/shelf_web_socket.dart:26` </location>
<code_context>
+/// The subprotocol is determined by looking at the client's
 /// `Sec-WebSocket-Protocol` header and selecting the first entry that also
 /// appears in [protocols]. If no subprotocols are shared between the client and
-/// the server, `null` will be passed instead and no subprotocol heaader will be
+/// the server, `null` will be passed instead and no subprotocol header will be
 /// sent to the client which may cause it to disconnect.
 ///
</code_context>

<issue_to_address>
**issue (typo):** Fixed typo: 'heaader' to 'header'.
</issue_to_address>

### Comment 3
<location> `pkgs/shelf_web_socket/CHANGELOG.md:9` </location>
<code_context>
+  `onConnection` callback. Previously this took an untyped function with either
+  one or two parameters. This now requires a `ConnectionCallback`; a typedef
+  taking two parameters. See also https://github.com/dart-lang/shelf/issues/457.
+* Add a API usage example.
+* Require Dart `^3.5.0`.
+
</code_context>

<issue_to_address>
**issue (typo):** Change 'a API' to 'an API' for correct grammar.

```suggestion
* Add an API usage example.
```
</issue_to_address>

### Comment 4
<location> `pkgs/shelf_web_socket/example/example.dart:16` </location>
<code_context>
    print('Serving at ws://${server.address.host}:${server.port}');
</code_context>

<issue_to_address>
**security (javascript.lang.security.detect-insecure-websocket):** Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections.

*Source: opengrep*
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue: Added ConnectionCallback typedef for connection handling.

Defining this typedef enhances maintainability and makes the API usage clearer.

[sourcery-ai]

issue (typo): Fixed typo: 'heaader' to 'header'.

[sourcery-ai]

issue (typo): Change 'a API' to 'an API' for correct grammar.

Suggested change

	* Add a API usage example.
	* Add an API usage example.

[sourcery-ai]

security (javascript.lang.security.detect-insecure-websocket): Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections.

Source: opengrep