Use gitoxide for robust diffing
#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has updates, yanks, deletions, and normalization
Disable all failing tests, bring tests into one executable.
4 tasks
The `index` module is now public for that reason.
That way the subtree can be recreated pretty easily
This greatly speeds up the usage of generated index repositories as these are only extracted, not build with tons of git invocations.
Note that the remote-check has been removed to support all kinds of indices. Change-checks will fail later should it not be in the correct format or an unrelated repo, so it should be fine.
no need to keep the worktree, all is bare
No need for crates.io checkout anymore
This comes with plenty of changes to the API of the `last_seen_reference()` and to the lower-level methods that take object ids (now `git::hash::ObjectId`. Note that `git2` is still used internally for fetching and cloning. This change was made to assure that at no time there are two open repositories (once for git2, once for `gitoxide`), as this has the potential to double resource usage for file handles.
Next up is normalization.
…that's unexpectedly low. What's the matter here?
The dependencies are re-ordered as well, so assuming that they don't actually change we can just leave them out of the hash entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When done, fixes #16.
Tasks
git2repo is held while agitoxiderepo is used for diffinggitoxidefor diffing, without normalizationgit-diffat leastgitoxideversion of diffThen merge and create a PR in docs.rs with the version update.