Skip to content

crates-index-diff 0.11.1 produces Added, not Yanked for immediately-yanked crate version #19

@jonhoo

Description

@jonhoo

I'm running crates-index-diff 0.11.1 over an index where the first commit is empty, and the second commit is

diff --git a/al/lo/allowed b/al/lo/allowed
new file mode 100644
index 0000000..b30662b
--- /dev/null
+++ b/al/lo/allowed
@@ -0,0 +1 @@
+{"name":"allowed","vers":"1.0.0","deps":[],"features":{},"cksum":"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855","yanked":true}

This used to produce a Changed::Yanked, but with 0.11.1 it produces Changed::Added instead. Which isn't specifically wrong, but it is a change in behavior I didn't expect and isn't in the changelog. I honestly don't know which it should produce. Maybe both, one immediately following the other? Figured I should at least document the change in behavior, and perhaps we should add a test for it?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions