random password bug #117
Description
User received this error:
[19-Apr-2024 14:22:29 UTC] PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function Newfold\WP\Module\Secure_Passwords\random_password(), 1 passed in /home1/USER/public_html/WEBSITE/wp-includes/class-wp-hook.php on line 324 and exactly 4 expected in /home1/USER/public_html/WEBSITE/wp-content/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-secure-passwords/secure-passwords.php:274
Stack trace:
#0 /home1/USER/public_html/WEBSITE/wp-includes/class-wp-hook.php(324): Newfold\WP\Module\Secure_Passwords\random_password('P6Au34sOAjVMf1n...')
#1 /home1/USER/public_html/WEBSITE/wp-includes/plugin.php(205): WP_Hook->apply_filters('P6Au34sOAjVMf1n...', Array)
#2 /home1/USER/public_html/WEBSITE/wp-content/plugins/post-and-page-builder/vendor/boldgrid/library/src/Util/Pluggable.php(151): apply_filters('random_password', 'P6Au34sOAjVMf1n...')
#3 /home1/USER/public_html/WEBSITE/wp-includes/class-wp-session-tokens.php(150): wp_generate_password(43, false, false)
#4 /home1/USER/public_html/WEBSITE/wp-includes/pluggable.php(1033): WP_Session_Tokens->create(1713709349)
#5 /home1/USER/public_html/WEBSITE/wp-content/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-sso/includes/SSO_Helpers.php(154): wp_set_auth_cookie(1)
#6 /home1/USER/public_html/WEBSITE/wp-content/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-sso/includes/SSO_Helpers_Legacy.php(46): NewFoldLabs\WP\Module\SSO\SSO_Helpers::triggerSuccess(Object(WP_User))
#7 /home1/USER/public_html/WEBSITE/wp-content/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-sso/includes/SSO_AJAX_Handler.php(39): NewFoldLabs\WP\Module\SSO\SSO_Helpers_Legacy::handleLegacyLogin('e3fb6c7d12b4a69...', 'd34f33253be9301...')
#8 /home1/USER/public_html/WEBSITE/wp-includes/class-wp-hook.php(324): NewFoldLabs\WP\Module\SSO\SSO_AJAX_Handler->legacyLogin('')
#9 /home1/USER/public_html/WEBSITE/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters('', Array)
#10 /home1/USER/public_html/WEBSITE/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#11 /home1/USER/public_html/WEBSITE/wp-admin/admin-ajax.php(192): do_action('wp_ajax_sso-che...')
#12 {main}
thrown in /home1/USER/public_html/WEBSITE/wp-content/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-secure-passwords/secure-passwords.php on line 274
[19-Apr-2024 14:22:29 UTC] PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home1/USER/public_html/WEBSITE/wp-content/plugins/bluehost-wordpress-plugin/vendor/wp-forge/wp-query-builder/src/Query.php on line 267
They are on BlueHost.
It happened about 2 years ago with someone else too: https://wordpress.org/support/topic/plugin-conflict-critical-errors/
The library is calling this:
return apply_filters( 'random_password', $password );... here.
WordPress uses it like this:
return apply_filters( 'random_password', $password, $length, $special_chars, $extra_special_chars );... here.
Extra parameters were added in 5.3.0
Seems our code is out of date, and has not been reflected with the latest parameters:
