Skip to content

fix(benchmarks): type err in ens benchmarks #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(benchmarks): type err in ens benchmarks #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab875c
attr lookups
BobTheBuidler Oct 20, 2025
537f3ed
chore: compile C files for source control
github-actions[bot] Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions build/__native_5f8b22f5f815a3776376.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107795,7 +107795,7 @@ CPyL54: ;
goto CPyL81;
CPyL55: ;
cpy_r_r61 = 0;
cpy_r_r62 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'syncing', 'status'}) */
cpy_r_r62 = CPyStatics[DIFFCHECK_PLACEHOLDER]; /* frozenset({'status', 'syncing'}) */
cpy_r_r63 = PyObject_GetIter(cpy_r_r62);
if (unlikely(cpy_r_r63 == NULL)) {
CPy_AddTraceback("faster_web3/_utils/method_formatters.py", "subscription_formatter", DIFFCHECK_PLACEHOLDER, CPyStatic_method_formatters___globals);
Expand Down Expand Up @@ -287910,7 +287910,7 @@ const char * const CPyLit_Str[] = {
"\003\beth_sign\021eth_signTypedData$RPC_METHODS_UNSUPPORTED_DURING_BATCH",
"\004\033faster_web3._utils.batching\004web3\016_requests_info\024_async_requests_info",
"\005\016RequestBatcher\ais_text\bis_bytes\alatin-1\nis_integer",
"\005\036unrecognized block reference: \rWeb3TypeError\bearliest\004safe\tfinalized",
"\005\036unrecognized block reference: \rWeb3TypeError\tfinalized\004safe\bearliest",
"\002\tis_string\006is_hex",
"\002=Value did not match any of the recognized block identifiers: \005curry",
"\003\tTypeGuard\021typing_extensions\"select_method_for_block_identifier",
Expand Down Expand Up @@ -288071,7 +288071,7 @@ const char * const CPyLit_Str[] = {
"\0020Storage key must be one of bytes, int, str, got \tto_0x_hex",
"\003)Storage key must be a 32-byte value, got \023to_checksum_address\abalance",
"\004\astorage\nis_address\022apply_formatter_if\021has_pretrace_keys",
"\004#type_aware_apply_formatters_to_dict\tis_hexstr\asyncing\006status",
"\004#type_aware_apply_formatters_to_dict\tis_hexstr\006status\asyncing",
"\004\017Block with id: \v not found.\nIndexError\030Unknown block identifier",
"\002\020Uncle at index: \023 of block with id: ",
"\002\'Unknown block identifier or uncle index\027Transaction with hash: ",
Expand Down Expand Up @@ -288556,8 +288556,8 @@ const int CPyLit_Tuple[] = {
323, 1, 1919, 1, 1918, 9, 76, 78, 79, 358, 81, 83, 85, 514, 87
};
const int CPyLit_FrozenSet[] = {
4, 5, 387, 300, 288, 388, 389, 3, 19, 1930, 0, 2, 884, 885, 4, 1086,
1085, 371, 1083
4, 5, 387, 288, 388, 389, 300, 3, 19, 1930, 0, 2, 884, 885, 4, 371,
1083, 1085, 1086
};
CPyModule *CPyModule_faster_ens__internal = NULL;
CPyModule *CPyModule_faster_ens;
Expand Down
25 changes: 12 additions & 13 deletions faster_web3/contract/async_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,26 +494,25 @@ def factory(
f"and could not be instantiated."
)

contract.functions = AsyncContractFunctions(
contract.abi, contract.w3, decode_tuples=contract.decode_tuples
w3 = contract.w3
decode_tuples = contract.decode_tuples
functions = AsyncContractFunctions(
contract_abi, w3, decode_tuples=decode_tuples
)
contract.functions = functions
contract.caller = AsyncContractCaller(
contract.abi,
contract.w3,
contract_abi,
w3,
contract.address,
decode_tuples=contract.decode_tuples,
contract_functions=contract.functions,
decode_tuples=decode_tuples,
contract_functions=functions,
)
contract.events = AsyncContractEvents(contract.abi, contract.w3)
contract.events = AsyncContractEvents(contract_abi, w3)
contract.fallback = AsyncContract.get_fallback_function(
contract.abi,
contract.w3,
AsyncContractFunction,
contract_abi, w3, AsyncContractFunction
)
contract.receive = AsyncContract.get_receive_function(
contract.abi,
contract.w3,
AsyncContractFunction,
contract_abi, w3, AsyncContractFunction
)
return contract

Expand Down
31 changes: 15 additions & 16 deletions faster_web3/contract/contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,35 +481,34 @@ def factory(
),
)

if contract.abi:
for abi in contract.abi:
abi_name = abi.get("name")
if contract_abi := contract.abi:
for abi in contract_abi:
abi_name: Optional[str] = abi.get("name")
if abi_name in ["abi", "address"]:
raise Web3AttributeError(
f"Contract contains a reserved word `{abi_name}` "
f"and could not be instantiated."
)

contract.functions = ContractFunctions(
contract.abi, contract.w3, decode_tuples=contract.decode_tuples
w3 = contract.w3
decode_tuples = contract.decode_tuples
functions = ContractFunctions(
contract_abi, w3, decode_tuples=decode_tuples
)
contract.functions = functions
contract.caller = ContractCaller(
contract.abi,
contract.w3,
contract_abi,
w3,
contract.address,
decode_tuples=contract.decode_tuples,
contract_functions=contract.functions,
decode_tuples=decode_tuples,
contract_functions=functions,
)
contract.events = ContractEvents(contract.abi, contract.w3)
contract.events = ContractEvents(contract_abi, w3)
contract.fallback = Contract.get_fallback_function(
contract.abi,
contract.w3,
ContractFunction,
contract_abi, w3, ContractFunction
)
contract.receive = Contract.get_receive_function(
contract.abi,
contract.w3,
ContractFunction,
contract_abi, w3, ContractFunction
)

return contract
Expand Down