BUG: Fixes issues when computing the FZ Quaternion from an input quaternion #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
topic/fix_getFZQuat
branch
3 times, most recently
from
4cac9e5 to
5f96e99
Compare
imikejackson
force-pushed
the
topic/fix_getFZQuat
branch
from
5f96e99 to
c6c500f
Compare
…ernion The code is take directly from the EMsoftOO code base.
imikejackson
force-pushed
the
topic/fix_getFZQuat
branch
from
c6c500f to
acf37bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is take directly from the EMsoftOO code base.
Unit test was added for this new functionality. Test data provided by MDG @ CMU.Edu