This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Add OpenACC data cleanup. #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that calls to acc_copyin(...) have corresponding calls to acc_delete(...), fixing errors (variable in data clause is partially present on the device) when repeatedly running CoreNEURON on GPU in the same process. Also fix handling of artificial cells to avoid problems with IntervalFire.
|
I re-ran the failing GitLab pipeline and it worked: https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/2536 -- the failure was related to BB5 infrastructure. |
pramodk
reviewed
Mar 29, 2021
This adds `nrn_newtonspace_delete_from_device` and `nrn_sparseobj_delete_from_device` methods that include `acc_delete` counterparts to `acc_copyin` calls.
pramodk
reviewed
Mar 30, 2021
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 30, 2021
With BlueBrain/CoreNeuron#515 this enables GPU execution of this test.
nrnhines
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 30, 2021
* Enable coreneuron_modtests::datareturn_py on GPU. With BlueBrain/CoreNeuron#515 this enables GPU execution of this test.
alexsavulescu
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 13, 2021
* Enable coreneuron_modtests::datareturn_py on GPU. With BlueBrain/CoreNeuron#515 this enables GPU execution of this test.
alexsavulescu
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 30, 2021
* Enable coreneuron_modtests::datareturn_py on GPU. With BlueBrain/CoreNeuron#515 this enables GPU execution of this test.
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Add OpenACC data cleanup. Ensure that calls to acc_copyin(...) have corresponding calls to acc_delete(...), fixing errors (variable in data clause is partially present on the device) when repeatedly running CoreNEURON on GPU in the same process. Also fix handling of artificial cells to avoid problems with IntervalFire. * Address comment, add more acc_delete calls. This adds `nrn_newtonspace_delete_from_device` and `nrn_sparseobj_delete_from_device` methods that include `acc_delete` counterparts to `acc_copyin` calls. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@b18835b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that calls to
acc_copyin(...)have corresponding calls toacc_delete(...), fixing errors such aswhen repeatedly running CoreNEURON on GPU in the same process.
Also fix handling of artificial cells to avoid problems with
IntervalFire.#513 remains valid, because #197 means that minor additional changes are required in NEURON.
How to test this?
Follow instructions in #513.
Test System
Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=master,