Excessive memory usage

[PeterSurda]

I got a report about excessive memory usage. At first I thought it's wrongly deployed because I haven't seen it in a long time, but after upgrading to latest code I could trigger it as well. I'm now doing a poor man's bisect to see where it broke.

[g1itch]

Perhaps the objgraph can help?

[PeterSurda]

I first need to find at least approximately when it was introduced and how to trigger it. So far I was only able to trigger it once, and only after the original reporter insisted he's running the current code. Is this a new bug that was introduced last year (as I can't reproduce it with older code) or a continuation of the old leaks that I thought were fixed?

I did indeed used objgraph last time I was tracing the leaks.

[g1itch]

Did you check this: 6ca3460? It comes to my mind first when I think about memleak.

[PeterSurda]

@g1itch that was a workaround for a weird bug in Python's threading, the automatic gc was occasionally triggeigr a RecursionError.

[g1itch]

Yes, I remember. But it still may be a good starting point for bisect.

[PeterSurda]

I can't reproduce it even with more recent code so it's unlikely a good starting point

[PeterSurda]

I was able to narrow it down a bit, between 7e1f1d2 (works ok) and 0331649 (can be triggered). That leaves only about 4 potential sources as most of the commits in between are code quality. Continuing testing.

[PeterSurda]

Narrowed it futher, it's most likely the first one of these two:

• a69732f ( Addrthread finish )
• 2a16538 ( Restrict outbound connections on network groups )

I'll narrow it down and try to write a minimal patch that stops the memory leak (even if it disables the functionality), and then I'll see how to fix the leak properly.

[PeterSurda]

Pretty sure now it's a69732f