Skip to content

feat(express): migrate coinSignTx to typed routes #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

feat(express): migrate coinSignTx to typed routes #7161

merged 1 commit into from
Oct 9, 2025
+532 −4

Conversation

lokesh-bitgo
Copy link
Contributor

@lokesh-bitgo lokesh-bitgo commented Oct 3, 2025 •
edited
Loading

Ticket: WP-5422

  • Migrated the coinSignTx route to a typed route.
  • Upgraded public-types to the latest version to use the TransactionRequest codec defined there.

@lokesh-bitgo lokesh-bitgo marked this pull request as ready for review October 3, 2025 12:57
@lokesh-bitgo lokesh-bitgo requested a review from a team as a code owner October 3, 2025 12:57
zahin-mohammad
zahin-mohammad reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have codecs for txRequests in public-types, can we re-use those instead?

@lokesh-bitgo lokesh-bitgo force-pushed the WP-5422-express-migrate-api-v-2-coin-signtx-to-typed-routes branch from 81482a7 to 01a7889 Compare October 9, 2025 01:51
@lokesh-bitgo lokesh-bitgo force-pushed the WP-5422-express-migrate-api-v-2-coin-signtx-to-typed-routes branch from 01a7889 to c2638e0 Compare October 9, 2025 03:23
@lokesh-bitgo lokesh-bitgo requested a review from a team as a code owner October 9, 2025 03:23
@lokesh-bitgo
Copy link
Contributor Author

I think we already have codecs for txRequests in public-types, can we re-use those instead?

Added TransactionRequest codec from public-types.

kisslove-dewangan
kisslove-dewangan approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@kisslove-dewangan kisslove-dewangan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mukeshsp
mukeshsp approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@mukeshsp mukeshsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from the SDK reviewers' side

@lokesh-bitgo lokesh-bitgo merged commit 255a86c into master Oct 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshsp mukeshsp mukeshsp approved these changes

@kisslove-dewangan kisslove-dewangan kisslove-dewangan approved these changes

@adityasoni-bitgo adityasoni-bitgo adityasoni-bitgo approved these changes

@kaustubhbitgo kaustubhbitgo Awaiting requested review from kaustubhbitgo kaustubhbitgo is a code owner automatically assigned from BitGo/wallet-platform

@zahin-mohammad zahin-mohammad Awaiting requested review from zahin-mohammad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lokesh-bitgo @mukeshsp @zahin-mohammad @kisslove-dewangan @adityasoni-bitgo