feat(sdk-coin-sol): support versioned sol transactions with customTx intent #7109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekchen745
changed the title
derekchen745
force-pushed
the
derek/SC-3231-support-sol-versioned-transactions
branch
10 times, most recently
from
7af5115 to
cad7c96
Compare
derekchen745
force-pushed
the
derek/SC-3231-support-sol-versioned-transactions
branch
2 times, most recently
from
df09add to
f5a95a3
Compare
derekchen745
force-pushed
the
derek/SC-3231-support-sol-versioned-transactions
branch
from
f5a95a3 to
c9dd588
Compare
derekchen745
force-pushed
the
derek/SC-3231-support-sol-versioned-transactions
branch
5 times, most recently
from
cfd8f71 to
343e386
Compare
derekchen745
force-pushed
the
derek/SC-3231-support-sol-versioned-transactions
branch
19 times, most recently
from
946226b to
bd1ed73
Compare
derekchen745
commented
Oct 7, 2025
| "webpack-prod": "NODE_OPTIONS=--max-old-space-size=4096 cross-env NODE_ENV=production webpack", | ||
| "test": "npm run coverage", | ||
| "unit-test": "mocha 'test/v2/unit/**/*.ts' 'test/unit/**/*.ts'", | ||
| "unit-test": "NODE_OPTIONS=--max-old-space-size=8192 mocha 'test/v2/unit/**/*.ts' 'test/unit/**/*.ts'", |
There was a problem hiding this comment.
The bitgo module unit-tests were failing with FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory. I tried optimizing and reviewing my changes in sdk-core, but it doesn’t seem like they should be causing the memory issue, so I bumped the memory to unblock for now.
haritkapadia
requested changes
Oct 7, 2025
modules/sdk-coin-sol/test/unit/transactionBuilder/customInstructionBuilder.ts
Show resolved
Hide resolved
derekchen745
force-pushed
the
derek/SC-3231-support-sol-versioned-transactions
branch
from
bd1ed73 to
d52e094
Compare
derekchen745
force-pushed
the
derek/SC-3231-support-sol-versioned-transactions
branch
from
d52e094 to
b33402f
Compare
haritkapadia
approved these changes
Oct 8, 2025
feng-bitgo
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SC-3231
We currently only support rebuilding Solana custom transactions in the legacy format. This PR adds support for Solana’s versioned transactions (with Address Lookup Tables) to enable WalletConnect compatibility, since most DApps rely on versioned transactions (Jupiter, Adrena, Kamino, etc)