feat(sdk-coin-hbar): add token enablement transaction verification #7003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshsp
previously approved these changes
Sep 17, 2025
mohammadalfaiyazbitgo
requested changes
Sep 19, 2025
mohammadalfaiyazbitgo
requested changes
Sep 19, 2025
| }); | ||
| }); | ||
|
|
||
| describe('Verify Token Enablement Transaction:', () => { |
There was a problem hiding this comment.
let's add a test that uses a valid transaction response from wallet platform with a spoofed txHex,
the test should have the structure of
await assert.rejects(
wallet.sendTokenEnablements(...)
)...
so we know a spoofed tx hex will throw an error on this flow.
There was a problem hiding this comment.
also another test verifying a valid token enablement tx won't cause an error.
There was a problem hiding this comment.
Tests on 685-725 and 726-774 are the two tests that address this.
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
2 times, most recently
from
8b832e3 to
e3e03ab
Compare
mohammadalfaiyazbitgo
previously approved these changes
Sep 25, 2025
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
from
564c306 to
a90a4e7
Compare
arvind-bg
reviewed
Sep 26, 2025
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
from
9eddfef to
acd50cf
Compare
mohammadalfaiyazbitgo
requested changes
Sep 29, 2025
| }); | ||
| }); | ||
|
|
||
| describe('Verify Token Enablement Transaction:', () => { |
There was a problem hiding this comment.
also another test verifying a valid token enablement tx won't cause an error.
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
from
acd50cf to
43e27d0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
2 times, most recently
from
b638a30 to
c7481dd
Compare
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
from
8ef38d8 to
6eb45c0
Compare
mohammadalfaiyazbitgo
previously approved these changes
Oct 2, 2025
modules/sdk-coin-hbar/src/hbar.ts
Outdated
| private validateNoTransfers(raw: HederaRawTransactionData): void { | ||
| if (raw.instructionsData?.params?.recipients?.length && raw.instructionsData.params.recipients.length > 0) { | ||
| const hasNonZeroTransfers = raw.instructionsData.params.recipients.some( | ||
| (recipient: any) => recipient.amount && recipient.amount !== '0' |
There was a problem hiding this comment.
please address the typing in a follow up.
modules/sdk-coin-hbar/src/hbar.ts
Outdated
Comment on lines
425
to
430
| const t = String(raw.instructionsData?.type || '').toLowerCase(); | ||
|
|
||
| if (t === 'contractexecute' || t === 'contractcall' || t === 'precompile') { | ||
| throw new Error(`Contract-based token association not allowed for blind enablement; got ${t}`); | ||
| } | ||
|
|
There was a problem hiding this comment.
please update the variable naming here.
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
2 times, most recently
from
6377c0b to
f65d214
Compare
mohammadalfaiyazbitgo
approved these changes
Oct 4, 2025
mukeshsp
reviewed
Oct 7, 2025
- Add validation functions for transaction structure, amount, account ID, token name, and transaction type - Integrate token enablement validation into verifyTransaction method - Add test coverage for all validation scenarios TICKET: WP-5746
SimonVutovB
force-pushed
the
WP-5746/hbar-verify-token-enablement-tx
branch
from
f65d214 to
2136fff
Compare
mukeshsp
approved these changes
Oct 8, 2025
kamleshmugdiya
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add verifyTokenEnablementTransaction method to validate token associate transactions with comprehensive checks for amount, account ID, token name, and transaction type. Integrates with existing verifyTransaction flow for enhanced token enablement validation.
TICKET: WP-5746