Skip to content

Conversation

almahmoud
Copy link

No description provided.

@lshep
Copy link

lshep commented Feb 1, 2023

As mentioned on slack I was already working on it and had spent the morning testing -- we can clean this up when we update python3

@lshep lshep closed this Feb 1, 2023
@almahmoud almahmoud reopened this Feb 1, 2023
@almahmoud
Copy link
Author

@lshep I understand, feel free to ignore this till the very end, I fixed all the conflicts in the meantime but I can update later. Don't want it to be a bother at all, since it's mostly aesthetic, but I guess my main goal is to decode everything at the first assignment of the variable so that the main string is decoded once and not have to decode all the substrings downstream of the code, to make it easier to read and update in the future

@lshep
Copy link

lshep commented Feb 1, 2023

We can leave this open and come back to it. The code I pushed up this morning is tested locally and on the testing instance. If we really are aiming at doing the branch renaming in the next two weeks or so I have to prepare other repos and scripts and not focus on the hooks -- I can test this out and merge after those are taken care of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants