Skip to content

Add bulk_optional_str for TrackingUrlTemplate field in case of Bulk AdExtensions and fix for ProductAudienceType in BulkProductAudience #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add bulk_optional_str for TrackingUrlTemplate field in case of Bulk AdExtensions and fix for ProductAudienceType in BulkProductAudience #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bingads/v13/bulk/entities/ad_extensions/bulk_filterlink_ad_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def filter_link_ad_extension(self, value):
),
_SimpleBulkMapping(
header=_StringTable.TrackingTemplate,
field_to_csv=lambda c: bulk_str(c.filter_link_ad_extension.TrackingUrlTemplate),
field_to_csv=lambda c: bulk_optional_str(c.filter_link_ad_extension.TrackingUrlTemplate),
csv_to_field=lambda c, v: setattr(c.filter_link_ad_extension, 'TrackingUrlTemplate', v if v else None)
),
_SimpleBulkMapping(
Expand Down
2 changes: 1 addition & 1 deletion bingads/v13/bulk/entities/ad_extensions/bulk_flyer_ad_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def flyer_ad_extension(self, value):
),
_SimpleBulkMapping(
header=_StringTable.TrackingTemplate,
field_to_csv=lambda c: bulk_str(c.flyer_ad_extension.TrackingUrlTemplate),
field_to_csv=lambda c: bulk_optional_str(c.flyer_ad_extension.TrackingUrlTemplate),
csv_to_field=lambda c, v: setattr(c.flyer_ad_extension, 'TrackingUrlTemplate', v if v else None)
),
_SimpleBulkMapping(
Expand Down
2 changes: 1 addition & 1 deletion bingads/v13/bulk/entities/ad_extensions/bulk_price_ad_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def price_ad_extension(self, value):
),
_SimpleBulkMapping(
header=_StringTable.TrackingTemplate,
field_to_csv=lambda c: bulk_str(c.price_ad_extension.TrackingUrlTemplate),
field_to_csv=lambda c: bulk_optional_str(c.price_ad_extension.TrackingUrlTemplate),
csv_to_field=lambda c, v: setattr(c.price_ad_extension, 'TrackingUrlTemplate', v if v else None)
),
_SimpleBulkMapping(
Expand Down
2 changes: 1 addition & 1 deletion bingads/v13/bulk/entities/ad_extensions/bulk_sitelink_ad_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def sitelink_ad_extension(self, value):
),
_SimpleBulkMapping(
header=_StringTable.TrackingTemplate,
field_to_csv=lambda c: bulk_str(c.sitelink_ad_extension.TrackingUrlTemplate),
field_to_csv=lambda c: bulk_optional_str(c.sitelink_ad_extension.TrackingUrlTemplate),
csv_to_field=lambda c, v: setattr(c.sitelink_ad_extension, 'TrackingUrlTemplate', v if v else None)
),
_SimpleBulkMapping(
Expand Down
2 changes: 1 addition & 1 deletion bingads/v13/bulk/entities/ad_extensions/bulk_video_ad_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def video_ad_extension(self, value):
),
_SimpleBulkMapping(
header=_StringTable.TrackingTemplate,
field_to_csv=lambda c: bulk_str(c.video_ad_extension.TrackingUrlTemplate),
field_to_csv=lambda c: bulk_optional_str(c.video_ad_extension.TrackingUrlTemplate),
csv_to_field=lambda c, v: setattr(c.video_ad_extension, 'TrackingUrlTemplate', v if v else None)
),
_SimpleBulkMapping(
Expand Down
2 changes: 1 addition & 1 deletion bingads/v13/bulk/entities/audiences/bulk_product_audience.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(self,
csv_to_field=lambda c, v: setattr(c.product_audience, 'TagId', int(v) if v else None)
),
_SimpleBulkMapping(
_StringTable.Audience,
_StringTable.ProductAudienceType,
field_to_csv=lambda c: bulk_str(c.product_audience.ProductAudienceType),
csv_to_field=lambda c, v: setattr(c.product_audience, 'ProductAudienceType', v)
),
Expand Down
4 changes: 2 additions & 2 deletions bingads/v13/bulk/entities/bulk_ads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def ad(self, ad):
),
_SimpleBulkMapping(
header=_StringTable.TrackingTemplate,
field_to_csv=lambda c: bulk_str(c.ad.TrackingUrlTemplate),
field_to_csv=lambda c: bulk_optional_str(c.ad.TrackingUrlTemplate),
csv_to_field=lambda c, v: setattr(c.ad, 'TrackingUrlTemplate', v if v else None)
),
_SimpleBulkMapping(
Expand Down Expand Up @@ -807,4 +807,4 @@ def process_mappings_from_row_values(self, row_values):
def process_mappings_to_row_values(self, row_values, exclude_readonly_data):
self._validate_property_not_null(self.responsive_search_ad, 'responsive_search_ad')
super(BulkResponsiveSearchAd, self).process_mappings_to_row_values(row_values, exclude_readonly_data)
self.convert_to_values(row_values, BulkResponsiveSearchAd._MAPPINGS)
self.convert_to_values(row_values, BulkResponsiveSearchAd._MAPPINGS)