Skip to content

Updated last_completed_available_date dateformat due to bing api changes #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated last_completed_available_date dateformat due to bing api changes #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions bingads/v13/internal/reporting/row_report_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __init__(self, stream_reader):

def read_header(self):
self._stream_reader.read_report_header(self)

def parse_header(self, fields):
valid_values = list(filter(lambda x: x is not None and len(x) > 0, [s.strip() for s in fields]))
if len(valid_values) == 1 and ':' in fields[0]:
Expand All @@ -32,7 +32,7 @@ def parse_header(self, fields):
return False
self._report_columns = fields
return True

def parse_meta(self, header):
res = self._regex.match(header)
if res:
Expand Down Expand Up @@ -74,38 +74,38 @@ def last_completed_available_date(self):
str_time = str_time[:str_time.rfind('(') - 1]

try:
return datetime.strptime(str_time, '%m/%d/%Y %I:%M:%S %p')
return datetime.strptime(str_time, '%m/%d/%Y %I:%M:%S%p')
except Exception:
dt_tokens = str_time.split(' ')
if len(dt_tokens) > 1:
return datetime.strptime(' '.join(dt_tokens[:2]), '%m/%d/%Y %H:%M:%S')
return None

@property
def record_count(self):
return int(self._row_number) if self._row_number else None


@property
def time_zone(self):
return self._time_zone

@property
def potential_incomplete_data(self):
return self._potential_incomplete_data

# @property
# def report_filter(self):
# return self._report_filter

@property
def report_aggregation(self):
return self._report_aggregation

@property
def report_name(self):
return self._report_name

@property
def report_time_start(self):
return self._report_time_start
Expand Down