Skip to content

Conversation

@tv
Copy link

@tv tv commented Jun 5, 2020

The current vault documents recommend having the lease_id in the body for easier policy management. So this PR does just that, moves lease_id to the body rather than having it in the url path.

@kurtdb
Copy link

kurtdb commented Aug 25, 2020

This solves an issue we are having: when trying to renew a lease, the current implementation of the vault (latest version) returns a http 403 when you put the leaseId in the request url: https://www.vaultproject.io/api-docs/system/leases#renew-lease

@igouss
Copy link

igouss commented Oct 26, 2020

Hi, can you please take a look at this patch. I have the same problem. Library is calling wrong URL.

@igouss
Copy link

igouss commented Oct 26, 2020

Meanwhile

            VaultResponse renew = vault.logical().write("sys/leases/renew", Map.of(
                    "lease_id", dataSource.getCredentials().getLeaseId(),
                    "interval", dataSource.getCredentials().getLeaseDuration()
            ));

@Sulion
Copy link

Sulion commented Nov 6, 2020

I think this lib is dead. ☠️ RIP.

@kurtdb
Copy link

kurtdb commented Nov 6, 2020

Maybe fork it and do some further development on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants