make x-vault-token optional, allows using Vault Agent #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@steve-perkins @steve-perkins-bc anything I can help to speed this up? Do you need someone to help maintain the repo? |
Contributor
Author
|
I wonder if it would help to rewrite the |
steve-perkins
approved these changes
Aug 16, 2019
| final RestResponse restResponse = new Rest()//NOPMD | ||
| .url(vaultConfig.getAddress() + "/v1/sys/mounts") | ||
| .header("X-Vault-Token", vaultConfig.getToken()) | ||
| .optionalHeader("X-Vault-Token", vaultConfig.getToken()) |
Contributor
There was a problem hiding this comment.
Huh. It looks like another contributor added this optionalHeader(...) method back in February.
If I thought about it at the time, I would have gone back and done all of this other cleanup to use it consistently (it's cleaner, and should have been like that to begin with). Thanks for doing so.
Contributor
|
Thanks, @Casz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #183
Added a vault agent test container to validate the fix.