Skip to content

PKI Issue Private Key Format #190

@kb

Description

@kb

Hi There!

I'm looking to thread through the private_key_format option for the PKI issue API. I see a PR that was not merged that has the functionality I'm looking for, but does appear to introduce a breaking API change.

The most straight forward change would be something like the PR above, but a breaking change would mean a major version revision which y'all may not want. Alternatively with some code duplication a new API could be added to avoid breaking existing APIs. Do you have a preference for the direction here? I also noticed there are other vault options that would be nice to support as well. Maybe a new version of the API could be introduced that takes a configuration object instead of positional arguments?

I'm happy to take on the changes, just wanted to get some direction before starting in on things.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions