Skip to content

Remove link to outdated multiapi generation script #41987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jul 11, 2025

Description

#41943 removed multiapi_init_gen.py, breaking the link in this doc. @msyyc, let me know if we should more significantly overhaul this multiapi.md or remove it altogether.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp requested review from msyyc and Copilot July 11, 2025 18:51
@mccoyp mccoyp requested a review from scbedd as a code owner July 11, 2025 18:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the broken link to the now-deleted multiapi_init_gen.py script from the multiapi documentation.

  • Deleted the outdated reference to multiapi_init_gen.py
  • No functional code changes
Comments suppressed due to low confidence (1)

doc/dev/mgmt/multiapi.md:106

  • [nitpick] Grammatical error: 'There is as many folder per API versions we want to ship' should be 'There are as many folders as API versions we want to ship.'
- There is as many folder per API versions we want to ship

@msyyc
Copy link
Member

msyyc commented Jul 14, 2025

@mccoyp Thanks for your PR. multiapi feature in codegen will be deprecated in several months but now it is still in use so we had better keep this doc until we drop the feature.

@mccoyp mccoyp merged commit 9254a9e into main Jul 14, 2025
19 checks passed
@mccoyp mccoyp deleted the multiapi-doc-link branch July 14, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants