-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[ServiceBus/EventHub] move async ssl opts to transport constructor #37655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ServiceBus/EventHub] move async ssl opts to transport constructor #37655
Conversation
|
/azp run python - eventhub - tests |
|
/azp run python - servicebus - tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
l0lawrence
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
|
Is it an acceptable solution to move blocking IO to the constructor of the class? A common use case of these objects is to dynamically create (I'm the reporter for the issue #37246) |
|
Hi @sveinse - We will discuss and let you know. Thanks. |
|
@swathipil thank you. If you're not aware of the comments in #37246 , please consider the new comments #37246 (comment) and onwards. Thanks. |
…zure#37655) * [ServiceBus/EventHub] move async ssl opts to o transport constructor * changelog
…zure#37655) * [ServiceBus/EventHub] move async ssl opts to o transport constructor * changelog
addresses: #37246
Creating the SSLContext and loading verify locations can be done in the constructor. Moving the check to the constructor so it doesn't need to be run in a ThreadPoolExecutor.
TODO: