Skip to content

Telemetry support for App Configuration #35254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Sep 11, 2024
Merged

Telemetry support for App Configuration #35254

merged 26 commits into from
Sep 11, 2024

Conversation

@mrm9084
Copy link
Member

@mrm9084 mrm9084 commented Apr 17, 2024

Description

Adds telemetry values into Feature Flags.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 17, 2024

API change check

API changes are not detected in this pull request.

avanigupta
avanigupta reviewed Apr 26, 2024
View reviewed changes
@mrm9084 mrm9084 marked this pull request as draft April 30, 2024 17:54
@mrm9084
Copy link
Member Author

mrm9084 commented Apr 30, 2024

I have changed this to draft, as we don't want to merge this into main, it will be a beta release.

@mrm9084 @avanigupta
Update sdk/appconfiguration/azure-appconfiguration-provider/azure/app…
958761e 
…configuration/provider/_azureappconfigurationprovider.py

Co-authored-by: Avani Gupta <[email protected]>
@mrm9084 mrm9084 marked this pull request as ready for review July 2, 2024 17:30
@mrm9084 mrm9084 merged commit 04e0fda into main Sep 11, 2024
@mrm9084 mrm9084 deleted the TelemetrySupport branch September 11, 2024 22:50
@zhiyuanliang-ms zhiyuanliang-ms mentioned this pull request Sep 20, 2024
Merged
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@mrm9084 @avanigupta @l0lawrence
Telemetry support for App Configuration (Azure#35254)
de07fbb 
* Adding Telemetry

* Telemetry Support

* fixing formatting

* Update _azureappconfigurationprovider.py

* Update _azureappconfigurationproviderasync.py

* formatting

* changing doc style due to pylint-next

* fixing kwargs docs

* Formatting

* Review comments

* Changed label checking.

* black format changes

* pylint

* Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py

Co-authored-by: Avani Gupta <[email protected]>

* added space checks

* Update conftest.py

* moved telemetry to client wrapper

* fixing format

* updating after merge

* fixing black issue

* removing unused imports

---------

Co-authored-by: Avani Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rossgrambo rossgrambo rossgrambo approved these changes

@albertofori albertofori Awaiting requested review from albertofori albertofori is a code owner

@avanigupta avanigupta Awaiting requested review from avanigupta avanigupta is a code owner

Assignees

No one assigned

Labels

App Configuration Provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mrm9084 @azure-sdk @avanigupta @rossgrambo @albertofori