Move common code + class definition updates

[scbedd]

Addresses:

• Clean up class definition per this comment
• Move some isManagement or isReleaseBranch to SpecModel or common helpers.
  • Utilize changed-files utilities instead of redetecting in IsDataPlanePR and isManagementPR
  • Moved isReleaseBranch to common code.

[openapi-pipeline-app]

Next Steps to Merge

Next steps that must be taken to merge this PR:

• ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

[openapi-pipeline-app]

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

[scbedd]

I did notice this looks odd. Was this intentional? If so I'll continue leaving this alone.

[scbedd]

I didn't really see a good place to put something branch related like this. I DID consider sdk-types.js, but that seemed like it was type related specifically so I didn't put it there.

[mikeharder]

Suggested change

	name;
	#name;

[mikeharder]

Suggested change

	present;
	#present;

[mikeharder]

Suggested change

	shouldBePresent;
	#shouldBePresent;

[mikeharder]

Approved pending rename of private fields

[scbedd]

Approved pending rename of private fields

They're not private. They need to be accessible as various code points interact with those values directly. I'll check how hard it will be to refactor so they actually are private tho.

[mikeharder]

Approved pending rename of private fields

They're not private. They need to be accessible as various code points interact with those values directly. I'll check how hard it will be to refactor so they actually are private tho.

If they only need to be read (not written) by callers, you can add a getter:

azure-rest-api-specs/.github/shared/src/swagger.js

Lines 176 to 181 in e6d4235

	/**
	* @returns {string} absolute path
	*/
	get path() {
	return this.#path;
	}