Skip to content

[HDInsight] imporve hdinsight test coverage #28344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

2258093686
Copy link
Member

Description

Increase test coverage from 40% to 90%

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 03:58
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

This comment was marked as outdated.

@2258093686 2258093686 marked this pull request as draft August 7, 2025 04:03
@2258093686 2258093686 requested a review from Copilot August 7, 2025 04:11
Copilot

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot August 7, 2025 05:42
Copilot

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot August 7, 2025 05:58
Copilot

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot August 7, 2025 06:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve HDInsight test coverage from 40% to 90% by adding new test scenarios and updating existing test configurations to use consistent parameters and settings.

  • Added new test methods for HDInsight job management commands, cluster management, and configuration pipelining
  • Updated test parameters to use consistent resource group names, locations, and HDInsight versions
  • Modified existing tests to use pre-existing resources instead of creating new ones where appropriate

Reviewed Changes

Copilot reviewed 10 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
TestManagementCluster.json New session recording file for cluster management test scenarios
HDInsightScriptActionTests.ps1 Added version parameter to cluster creation command
HDInsightMonitoringTests.ps1 Changed location to East Asia and added version parameter
HDInsightConfigurationTests.ps1 Added comprehensive test for cluster creation via configuration pipelining
HDInsightConfigurationTests.cs Added test method for configuration pipelining scenario
HDInsightClusterTests.ps1 Added job management tests, management cluster tests, and updated autoscale test parameters
HDInsightClusterTests.cs Added test methods and enabled previously skipped autoscale test
HDInsightAzureMonitorTests.ps1 Modified to use existing cluster and workspace instead of creating new ones
HDInsightAzureMonitorTests.cs Enabled previously skipped Azure Monitor test
Common.ps1 Updated default parameters to use consistent resource names and added version parameter

@2258093686 2258093686 assigned 2258093686 and unassigned 2258093686 Aug 7, 2025
@2258093686 2258093686 marked this pull request as ready for review August 7, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants