-
Notifications
You must be signed in to change notification settings - Fork 4k
[HDInsight] imporve hdinsight test coverage #28344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
2258093686
wants to merge
5
commits into
Azure:main
Choose a base branch
from
2258093686:imporve-test-coverage-hdinsight
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve HDInsight test coverage from 40% to 90% by adding new test scenarios and updating existing test configurations to use consistent parameters and settings.
- Added new test methods for HDInsight job management commands, cluster management, and configuration pipelining
- Updated test parameters to use consistent resource group names, locations, and HDInsight versions
- Modified existing tests to use pre-existing resources instead of creating new ones where appropriate
Reviewed Changes
Copilot reviewed 10 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
TestManagementCluster.json | New session recording file for cluster management test scenarios |
HDInsightScriptActionTests.ps1 | Added version parameter to cluster creation command |
HDInsightMonitoringTests.ps1 | Changed location to East Asia and added version parameter |
HDInsightConfigurationTests.ps1 | Added comprehensive test for cluster creation via configuration pipelining |
HDInsightConfigurationTests.cs | Added test method for configuration pipelining scenario |
HDInsightClusterTests.ps1 | Added job management tests, management cluster tests, and updated autoscale test parameters |
HDInsightClusterTests.cs | Added test methods and enabled previously skipped autoscale test |
HDInsightAzureMonitorTests.ps1 | Modified to use existing cluster and workspace instead of creating new ones |
HDInsightAzureMonitorTests.cs | Enabled previously skipped Azure Monitor test |
Common.ps1 | Updated default parameters to use consistent resource names and added version parameter |
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightConfigurationTests.ps1
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightConfigurationTests.ps1
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase test coverage from 40% to 90%
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.