Skip to content

Add the AzureFunctions feeds as a NuGet package sources #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2023
Merged

Add the AzureFunctions feeds as a NuGet package sources #934

merged 3 commits into from
Mar 21, 2023

Conversation

@Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Mar 21, 2023

Issue describing the changes in this PR

Resolves #933

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Mar 21, 2023

/cc @kashimiz

@kashimiz
Copy link

kashimiz commented Mar 21, 2023

Confirmed offline with @Francisco-Gamino that build results are as expected. Looks good to me.

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Mar 21, 2023

Confirmed offline with @Francisco-Gamino that build results are as expected. Looks good to me.

Thank you @kashimiz for the PR review.

@Francisco-Gamino Francisco-Gamino merged commit 87ff1d2 into dev Mar 21, 2023
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/update-nuget-config branch March 22, 2023 02:25
Francisco-Gamino added a commit that referenced this pull request Mar 22, 2023
@Francisco-Gamino
Add the AzureFunctions feeds as a NuGet package sources (#934)
079b372 
* Remove feeds from myget.org

* Add AzureFunctions@internalrelease feed

* Add AzureFunctions@staging feed
@Francisco-Gamino Francisco-Gamino mentioned this pull request Mar 22, 2023
Merged
7 tasks
Francisco-Gamino added a commit that referenced this pull request Mar 22, 2023
@Francisco-Gamino
Add the AzureFunctions feeds as a NuGet package sources (#934)
352bcf9 
* Remove feeds from myget.org

* Add AzureFunctions@internalrelease feed

* Add AzureFunctions@staging feed
@Francisco-Gamino Francisco-Gamino mentioned this pull request Mar 22, 2023
Merged
7 tasks
Francisco-Gamino added a commit that referenced this pull request Mar 22, 2023
@Francisco-Gamino
Add the AzureFunctions feeds as a NuGet package sources (#934) (#935)
6ed9485 
* Remove feeds from myget.org

* Add AzureFunctions@internalrelease feed

* Add AzureFunctions@staging feed
Francisco-Gamino added a commit that referenced this pull request Mar 22, 2023
@Francisco-Gamino
Add the AzureFunctions feeds as a NuGet package sources (#934) (#936)
24111cf 
* Remove feeds from myget.org

* Add AzureFunctions@internalrelease feed

* Add AzureFunctions@staging feed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

1 more reviewer

@michaelpeng36 michaelpeng36 michaelpeng36 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove myget.org dependencies from NuGet.config

4 participants

@Francisco-Gamino @kashimiz @michaelpeng36