Skip to content

Conversation

@alrod
Copy link
Member

@alrod alrod commented Apr 1, 2022

Resolves #785

PowerShell supports WorkerStatus requests but function hosts does not call the api as there is no corresponding capability:
PowerShell worker WorkerStatus support:
https://github.com/Azure/azure-functions-powershell-worker/blob/dev/src/RequestProcessor.cs#L57
Function Host check for WorkerStatus capability:
https://github.com/Azure/azure-functions-host/blob/dev/src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs#L162

@alrod alrod requested a review from Francisco-Gamino April 1, 2022 23:39
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino
Copy link
Contributor

Hi @alrod -- Thank you for making this change. After the PR is merged, I will port this change to the PowerShell language worker 7.0 and 7.2 on V3 and V4.

@alrod alrod merged commit c77e1b7 into dev Apr 4, 2022
Francisco-Gamino added a commit that referenced this pull request Apr 6, 2022
Francisco-Gamino added a commit that referenced this pull request Apr 6, 2022
Francisco-Gamino added a commit that referenced this pull request Apr 7, 2022
davidmrdavid pushed a commit that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WorkerStatus capability to PowerShell language worker

5 participants