-
Notifications
You must be signed in to change notification settings - Fork 54
Allow DF Activity Functions to have multiple output bindings #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm unsure if I need to mark the checkbox to backport this PR, please let me know! |
|
I think this PR would be a good candidate for backporting due to the generic nature of the issue. However, for now, I think we should restrict this change to the |
|
Thanks @michaelpeng36! I'd appreciate a review as well to move this along :) @AnatoliB: do you agree with Michael's backporting versions suggestion? I want to make sure we target the version of the affected customer |
michaelpeng36
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @davidmrdavid -- We should port this fix to |
Yes, these are the correct branches. |
Issue describing the changes in this PR
resolves #646
replaces #700
Pull request checklist
release_notes.mdAdditional information
Previously, the Function
BindOutputFromResultwould only bind output values for non-DF Function types. It appears this was put in place to prevent DF orchestrators from having multiple output bindings. However, the implementation also prevented Activity Functions from having multiple output bindings, which led to the bug report linked above.This PR refines the logic to apply only to orchestrators.