Skip to content

Conversation

@Francisco-Gamino
Copy link
Contributor

Issue describing the changes in this PR

A Cosmos DB error code changed and the E2E test fails because it is not retrying ReadDocument when it should be.

Note: I will port this change via cherry pick to the v3.x/ps7 and v4.x/ps7.0 branches.

Pull request checklist

  • My changes do not require documentation changes
    • [] Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Nov 3, 2021

/cc @ejizba @AnatoliB @michaelpeng36

@Francisco-Gamino
Copy link
Contributor Author

Thank you @ejizba for investigating and resolving the Cosmos DB E2E test issue.

@kaibocai @amamounelsayed -- You will need a similar fix for the Java language worker E2E tests.

Copy link
Contributor

@michaelpeng36 michaelpeng36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino Francisco-Gamino merged commit 5bb89f9 into dev Nov 3, 2021
Francisco-Gamino added a commit that referenced this pull request Nov 3, 2021
@Francisco-Gamino Francisco-Gamino mentioned this pull request Nov 3, 2021
7 tasks
Francisco-Gamino added a commit that referenced this pull request Nov 3, 2021
@Francisco-Gamino Francisco-Gamino mentioned this pull request Nov 3, 2021
7 tasks
Francisco-Gamino added a commit that referenced this pull request Nov 3, 2021
Francisco-Gamino added a commit that referenced this pull request Nov 3, 2021
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/fix-cosmos-db-e2e-tests branch February 4, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants