Skip to content

Log PowerShell version #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

Log PowerShell version #396

merged 1 commit into from
Jan 31, 2020

Conversation

@AnatoliB
Copy link
Contributor

@AnatoliB AnatoliB commented Jan 31, 2020 •
edited
Loading

We'll need this in both v3.x/ps6 and v3.x/ps7 branches. It is not strictly necessary in v2, so I will not propagate it to the v2.x branch at this point.

Francisco-Gamino
Francisco-Gamino approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Francisco-Gamino
Copy link
Contributor

Francisco-Gamino commented Jan 31, 2020

Just curious if you happen to have an example of how the version information would look like in the logs?

@AnatoliB
Copy link
Contributor Author

AnatoliB commented Jan 31, 2020

Just curious if you happen to have an example of how the version information would look like in the logs?

It will be the same as what you would see in response to $PSVersionTable.PSVersion.ToString() in a PowerShell console, for example: 7.0.0-rc.2

@AnatoliB AnatoliB merged commit 27da9e6 into Azure:dev Jan 31, 2020
@AnatoliB AnatoliB deleted the log-powershell-version branch January 31, 2020 23:14
@AnatoliB AnatoliB restored the log-powershell-version branch February 3, 2020 21:19
@AnatoliB AnatoliB deleted the log-powershell-version branch February 3, 2020 21:22
AnatoliB added a commit to AnatoliB/azure-functions-powershell-worker that referenced this pull request Feb 3, 2020
@AnatoliB
Log PowerShell version (Azure#396)
bab62a9
@AnatoliB AnatoliB mentioned this pull request Feb 3, 2020
Merged
AnatoliB added a commit that referenced this pull request Feb 3, 2020
@AnatoliB
Log PowerShell version (#396) (#397)
2370855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnatoliB @Francisco-Gamino