Skip to content

Use Get-Error instead of custom error formatting logic #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

Use Get-Error instead of custom error formatting logic #395

merged 2 commits into from
Jan 31, 2020

Conversation

@AnatoliB
Copy link
Contributor

@AnatoliB AnatoliB commented Jan 30, 2020

Resolves #384

Francisco-Gamino
Francisco-Gamino approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino
Copy link
Contributor

Francisco-Gamino commented Jan 31, 2020

Code change looks good.
Quick question: This change only applies to PS7, right?

@AnatoliB
Copy link
Contributor Author

AnatoliB commented Jan 31, 2020

Code change looks good.
Quick question: This change only applies to PS7, right?

Correct. So, this change is going to the dev branch, and subsequently to v3.x/ps7, but will never go to v2.x nor v3.x/ps6.

@AnatoliB AnatoliB merged commit 12f9ddc into Azure:dev Jan 31, 2020
@AnatoliB AnatoliB deleted the ps7-error-formatting branch January 31, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

For PowerShell 7, use the new Get-Error cmdlet instead of the custom error formatting logic

2 participants

@AnatoliB @Francisco-Gamino