Skip to content

Log CommandNotFoundException raised by function code #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Log CommandNotFoundException raised by function code #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be1e84f
Trace "Command not found" events
AnatoliB Oct 10, 2019
ee16f62
Move message strings to resources
AnatoliB Oct 10, 2019
fc2c9c0
Check FullyQualifiedErrorId instead of exception type
AnatoliB Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/PowerShell/PowerShellManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,11 @@ internal Hashtable InvokeFunction(
}
catch (RuntimeException e)
{
if (e.ErrorRecord.FullyQualifiedErrorId == "CommandNotFoundException")
{
_logger.Log(isUserOnlyLog: false, LogLevel.Warning, PowerShellWorkerStrings.CommandNotFoundException_Exception);
}

Logger.Log(isUserOnlyLog: true, LogLevel.Error, GetFunctionExceptionMessage(e));
throw;
}
Expand Down
5 changes: 5 additions & 0 deletions src/PowerShell/StreamHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ public void ErrorDataAdding(object sender, DataAddingEventArgs e)
{
if(e.ItemAdded is ErrorRecord record)
{
if (record.FullyQualifiedErrorId == "CommandNotFoundException")
{
_logger.Log(isUserOnlyLog: false, LogLevel.Warning, PowerShellWorkerStrings.CommandNotFoundException_Error);
}

_logger.Log(isUserOnlyLog: true, LogLevel.Error, $"ERROR: {_errorRecordFormatter.Format(record)}", record.Exception);
}
}
Expand Down
6 changes: 6 additions & 0 deletions src/resources/PowerShellWorkerStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,4 +298,10 @@
<data name="FailedToEnumerateDependencySnapshotContent" xml:space="preserve">
<value>Failed to enumerate dependency snapshot '{0}' content: {1}</value>
</data>
<data name="CommandNotFoundException_Error" xml:space="preserve">
<value>CommandNotFoundException detected (error).</value>
</data>
<data name="CommandNotFoundException_Exception" xml:space="preserve">
<value>CommandNotFoundException detected (exception).</value>
</data>
</root>