Managed Dependencies: handle paginated PSGallery response #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francisco-Gamino
approved these changes
Aug 21, 2019
Contributor
Francisco-Gamino
left a comment
Francisco-Gamino
left a comment
There was a problem hiding this comment.
Hi @AnatoliB, the code change LGTM.
Something to consider is that if while processing multiple pages, if the PSGallery becomes unavailable, then GetLatestPublishedModuleVersion will return the latest publish version up to point when we could not reach the PSGallery anymore. We should optimize this code later to detect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a module on the PowerShell Gallery contains many (100+) versions, PowerShell Gallery API returns a limited number of entries and a link to the next page. Before this fix, PS Worker would process the first page only, failing to detect the latest version correctly in some cases. This fix makes PS Worker request and process all the subsequent pages.