Shorten managed dependencies snapshot folder names #293
Conversation
AnatoliB
changed the title
Francisco-Gamino
left a comment
Francisco-Gamino
left a comment
There was a problem hiding this comment.
One minor comment; otherwise, LGTM.
| /// ".../20190710-1234.567890.r.i" | ||
| /// This makes it possible to enumerate all the installed snapshots by using ".../*.r" mask, | ||
| /// and all the installing snapshots by using ".../*.i" mask. | ||
| /// ".../1907101234567ri" |
There was a problem hiding this comment.
Should this be 1907101234567i?
There was a problem hiding this comment.
@AnatoliB: Please rebase your code. The unsuccessful checks should pass now :).
There was a problem hiding this comment.
Should this be 1907101234567i?
It could, but the code will actually do 1907101234567ri, for the sake of simplifying the transformation from the "ready" name to the "installing" name. Currently, we just append i, which is a no-brainer. If we wanted to do 1907101234567i instead, we would have to do a replacement, make a decision on how to handle the situation when the original name does not end with "i". Though not very difficult, these decisions complicate the problem without a valuable reason.
There was a problem hiding this comment.
That makes sense. Thanks for the clarification @AnatoliB.
2 participants
Shorten managed dependencies snapshot folder names: