Managed dependency download on background thread #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatishRanjan
requested review from
Francisco-Gamino,
TylerLeonhardt,
anirudhgarg and
daxian-dbw
SatishRanjan
changed the title
Contributor
Author
|
@daxian-dbw - could you please take a look at this PR |
daxian-dbw
requested changes
Apr 23, 2019
Contributor
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
PR CI was disabled.
@pragnagopa We cannot merge without CI runs. Can you please enable PR CIs for at least @SatishRanjan , @TylerLeonhardt and me?
pragnagopa
reviewed
Apr 23, 2019
Member
|
@daxian-dbw - I will work with @fabiocav to enable PR builds. |
checking for the ManagedDependency module path before setting up well known paths
Removing _powershellPool.Initialize(request.RequestId) as profile.ps1 can also have Az module specific code and needs to be run after Az module download is complete
Removing Initialize from PowerShellManagerPool
Member
|
Will enable builds ASAP. Will update this PR soon. |
daxian-dbw
requested changes
Apr 24, 2019
Member
|
Reopening PR to test CI integration |
…ntatical fixes and cleanup
daxian-dbw
requested changes
Apr 24, 2019
daxian-dbw
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the changes to download managed dependency on a background thread and show the managed dependency download in progress message on the azure portal and on the CLI console when a function invocation is triggered while managed dependency download is in-progress