-
Notifications
You must be signed in to change notification settings - Fork 54
Update the help content for 'Push-OutputBinding' #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do you want to also generate the markdown docs a with PlatyPS and store them in the repo? |
|
Good point. Let me create a |
|
should we include PlatyPS docgen in the build script then? |
Why? Do you want to generate those markdown files during every build but not checking them in the repo? |
|
It's more about helping us make sure our docs are always updated. But a CI check would also work for me like this one :) The ideal situation is making sure every parameter has docs, but I'm fine calling that out of scope if you want |
|
Thanks for clarifying, I get your point now. A check like that would be useful when we only have script cmdlet. I will add the check. |
| Position: 1 | ||
| Default value: * | ||
| Accept pipeline input: True (ByPropertyName, ByValue) | ||
| Accept wildcard characters: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is false but it does support wildcard characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug in PlatyPS? I don't think it's able to figure out if a parameter accepts wildcard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot change it manually, unless we revert the doc check code in build.
TylerLeonhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM only one question about the platyPS output
Update the help content for
Push-OutputBinding.Get-Helplooks as follows after the update: